Revert "Disable PerfFileStream while we wait for dotnet/runtime#67545 to be fixed. (#2371) - #2381
Merged
Conversation
kouvel
commented
Apr 18, 2022
kouvel
commented
Contributor
- Depends on Fix a race condition in the thread pool runtime#68171
- This reverts commit d8f1c47 from PR Disable PerfFileStream while we wait for dotnet/runtime#67545 to be f… #2371
…to be fixed. (#2371)" - Depends on dotnet/runtime#68171 - This reverts commit d8f1c47 from PR #2371
Member
|
@kouvel big thanks for the PR (and also the runtime bug fix!) I am going to apply "NO MERGE" label for now and remove it once the benchmarks can be re-enabled:
|
Contributor
Author
|
The dependency dotnet/runtime#68171 has been merged now |
Contributor
Author
|
Just before the cutoff time for preview 4 though, I'll have to check the snap commit after the snap to see if it got included |
Contributor
Author
|
dotnet/runtime#68171 made it into the preview 4 snap, so this PR should be unblocked |
!
This was referenced Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.